-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix toString() method in configuration implementations (apache#3599) #3658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
fix toString() method in configuration implementations (apache#3599) #3658
Conversation
Why? This makes debugging worse as we loosing information. |
hi @garydgregory , instead of AbstractConfiguration , shall I put my changes to all derived classes so that it can retain the additional info of subclasses. |
I am still -1 here: |
I discussed this with @garydgregory, and I agree that the Following the discussion in #3100, I also think it's a good idea to reduce verbosity in Log4j Core by default. With that in mind, I propose the following:
Let me know what you think. |
Added toString implementation to AbstractConfiguration and removed from all derived classes.